Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modifications to run sonar-scanner during travis build #49

Merged
merged 3 commits into from
Jun 5, 2018

Conversation

pmconrad
Copy link

This PR is mostly identical to #46, the only difference being that it is an internal PR (i. e. from a branch inside this repo, while the other is from by private repo).
Sonar-scanner should be executed for the PR (it was already executed when I pushed the branch to this repo, but should be run separately for the PR).

@pmconrad
Copy link
Author

@oxarbitrage
Copy link
Member

when i click the link i get redirected to a login screen. when i select github it goes briefly to the repo inside sonar but immediately back to the login page. seems an auth issue. @pmconrad you maybe need to add others to have access? if so, please add me.

@pmconrad
Copy link
Author

pmconrad commented Jun 4, 2018

Hm, perhaps try this link: https://sonarcloud.io/dashboard?id=BitShares-FC

@oxarbitrage oxarbitrage self-requested a review June 4, 2018 13:59
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. looks good. lets keep testing it merged into master.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants