adjust asserts in fc/crypto #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
secexp = (seed + z) % order implies that secexp < order. order is well-known and constant, at least until we switch to another curve (which is extremely unlikely). The assertion cannot be triggered. |
pmconrad
approved these changes
Jun 5, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue bitshares/bitshares-core#992
Adjusted some asserts in the fc/crypto area. Some should have been static_assert or FC_ASSERT.
The impact of the change from assert to static_assert is minor (we can catch them at compile time, so why not?).
The 1 switch from assert to FC_ASSERT in elliptic_common.cpp is a bit more impactful. Please consider the side effects as you do your review.
Hat tip to the EOS folks. More information: EOSIO/eos#3560