PM-14333 fix case of crowdin translation not adding annotations on string with format args #4505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseverns-livefront
requested review from
brian-livefront,
david-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4505 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 460 460
Lines 39768 39768
Branches 5647 5647
=======================================
Hits 35352 35352
Misses 2444 2444
Partials 1972 1972 ☔ View full report in Codecov by Sentry. |
SaintPatrck
approved these changes
Jan 6, 2025
| @@ -100,4 +100,20 @@ class StringRestExtensionsTest : BaseComposeTest() { | |||
| .onNodeWithText("On your computer, open a new browser tab and go to ") | |||
| .assertIsDisplayed() | |||
| } | |||
|
|
|||
| @Suppress("MaxLineLength") | |||
There was a problem hiding this comment.
Is this actually too long?
There was a problem hiding this comment.
yes by one char it seems,
running detekt without suppression fails.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14333 - follow up
📔 Objective
Since Crowdin does not add the to each translation, need to support the cases where there are format args.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes