Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[pm-337] Remove the continuation token from the ListResponseModel. #5192

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JimmyVo16
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-337

📔 Objective

Moved the ContinuationToken property from ListResponseModel to PagedListResponseModel, ensuring it only appears on the GET public/events endpoint and not on others that don’t require it.

📸 Screenshots

GET public/events doc

image

Spot-check GET /public/members doc to ensure that it doesn't have ContinuationToken

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@JimmyVo16 JimmyVo16 requested a review from a team as a code owner December 27, 2024 21:06
@JimmyVo16 JimmyVo16 requested a review from eliykat December 27, 2024 21:06
@JimmyVo16 JimmyVo16 self-assigned this Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.69%. Comparing base (cd7c4bf) to head (b99350f).

Files with missing lines Patch % Lines
...i/Models/Public/Response/PagedListResponseModel.cs 0.00% 2 Missing ⚠️
...dminConsole/Public/Controllers/EventsController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5192      +/-   ##
==========================================
- Coverage   43.70%   43.69%   -0.01%     
==========================================
  Files        1469     1470       +1     
  Lines       67901    67901              
  Branches     6156     6156              
==========================================
- Hits        29673    29671       -2     
- Misses      36934    36936       +2     
  Partials     1294     1294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

Logo
Checkmarx One – Scan Summary & Detailsceb54b10-683d-4b9a-bd14-974f293ece35

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 195 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 214 Attack Vector
LOW Log_Forging /src/Api/Tools/Controllers/SendsController.cs: 299 Attack Vector
LOW Log_Forging /src/Api/Tools/Controllers/SendsController.cs: 157 Attack Vector
LOW Log_Forging /src/Api/Tools/Controllers/SendsController.cs: 193 Attack Vector
LOW Log_Forging /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37 Attack Vector
LOW Log_Forging /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 220 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AuthRequestsController.cs: 87 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AuthRequestsController.cs: 75 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 470
MEDIUM CSRF /src/Api/Platform/Push/Controllers/PushController.cs: 42
MEDIUM Privacy_Violation /src/Api/Auth/Models/Request/Accounts/SetPasswordRequestModel.cs: 28
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 209
MEDIUM Privacy_Violation /src/Api/AdminConsole/Controllers/OrganizationAuthRequestsController.cs: 59
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 256
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 256
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 256
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 261

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants