Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

All alerts in macOS sample crash #211

Closed
7 of 9 tasks
zeromhz opened this issue May 15, 2017 · 1 comment
Closed
7 of 9 tasks

All alerts in macOS sample crash #211

zeromhz opened this issue May 15, 2017 · 1 comment
Labels
difficulty: beginner contributions welcome from all type: bug

Comments

@zeromhz
Copy link

zeromhz commented May 15, 2017

Platform

  • iOS
  • macOS
  • tvOS

In app purchase type

  • Consumable
  • Non-consumable
  • Auto-Renewable Subscription
  • Non-Renewing Subscription

Environment

  • Sandbox
  • Production

Version

0.9.2

Related issues

Report

Running the macOS sample on 10.12.x every time the sample shows an alert it crashes. To repro simply build the sample, run it, and click any of the buttons (presuming there is a proper IAP configuration behind it.)

SwiftyStoreKit_macOSDemo[8253:544747] [General] -[NSAlert beginSheetModalForWindow:completionHandler:] may only be invoked from the main thread. Behavior on other threads is undefined.

Putting the alert on the main thread fixes it but I'm not sure this is the right answer.

Issue summary

macOS sample crashes any time an alert is shown

What did you expect to happen

alert should show

What happened instead

app crashes
@bizz84 bizz84 modified the milestone: 0.9.0 May 18, 2017
bizz84 added a commit that referenced this issue May 18, 2017
@bizz84
Dispatch callback on main queue when retrieving products info and ref…
ff41038 
…reshing the receipt (#211)
@bizz84 bizz84 mentioned this issue May 18, 2017
Merged
@bizz84 bizz84 added type: bug difficulty: beginner contributions welcome from all labels May 18, 2017
@bizz84 bizz84 added this to the 0.10.0 milestone May 18, 2017
@bizz84 bizz84 added the status: work in progress integration is in progress / being tested label May 18, 2017
@bizz84 bizz84 removed this from the 0.10.0 milestone May 18, 2017
@bizz84
Copy link
Owner

bizz84 commented May 18, 2017

Fixed on release 0.9.3.

@bizz84 bizz84 closed this as completed May 18, 2017
@bizz84 bizz84 removed the status: work in progress integration is in progress / being tested label May 18, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
difficulty: beginner contributions welcome from all type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bizz84 @zeromhz