Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add errorBuilder route to NotFoundScreen #149

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

bizz84
Copy link
Owner

@bizz84 bizz84 commented Mar 14, 2024

Related: #148.

This fixes the issue by showing a NotFoundScreen when navigating programmatically to a route that doesn't exist.

Also added a rewrites section to firebase.json:

{
  "hosting": {
    "public": "build/web",
    "ignore": [
      "firebase.json",
      "**/.*",
      "**/node_modules/**"
    ],
    "rewrites": [
      {
        "source": "**",
        "destination": "/index.html"
      }
    ]    
  }
}

@bizz84 bizz84 merged commit a756a90 into master Mar 14, 2024
1 check passed
@bizz84 bizz84 deleted the 148-go-router-error-builder branch March 14, 2024 09:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant