Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix dependencies #3

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Fix dependencies #3

merged 5 commits into from
Sep 4, 2024

Conversation

huddlej
Copy link
Collaborator

@huddlej huddlej commented Sep 3, 2024

Fixes errors in CI related to upstream changes in dependencies:

  1. For pandas versions before 2.2, pin numpy to version 1. This should fix CI for Python 3.9.
  2. deepdiff depends on PyYAML which broke in versions <6.0.1 when Cython 3 came out (don't ask). This should fix CI for Python 3.10 and 3.11 by bumping deepdiff to the second-to-last major version.

For pandas versions before 2.2, pin numpy to version 1 [1]. This commit
should fix CI for Python 3.9.

[1] pandas-dev/pandas#55519
Pins deepdiff to the latest version (8) which includes a fix a PyYAML
dependency issue with Cython [1]. Also, replaces the deep diff CLI
command in a functional test with a custom Python script that uses the
DeepDiff class, working around an issue where the deep diff CLI did not
properly recognize numeric values and caused the functional test to fail
spuriously. This commit should fix CI for Python versions 3.10 and 3.11.

[1] seperman/deepdiff#406
@huddlej huddlej merged commit 1406e14 into main Sep 4, 2024
4 checks passed
@huddlej huddlej deleted the fix-deps branch September 4, 2024 17:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant