Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

rustls: features guide backend #304

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Apr 24, 2024

rustls replaced ring with aws-lc-rs as default crypto backend,
expose features to select between the two, along with a feature on whether to enable tls 1.2

@serprex
Copy link
Contributor Author

serprex commented Apr 24, 2024

as an aside, rust features are supposed to be additive, this is not currently the case with rustls/native-tls features. If both features are enabled the compile fails. Would you be interested in having changes made to rectify that?

I think the fix would be to have each crypto backend use a different Opts (ie, ssl_opts would be ssl_opts_native & ssl_opts_rustls). Could get more complicated with traits, but doesn't seem necessary

@westy92
Copy link
Contributor

westy92 commented Jul 23, 2024

Completed as part of #313

@serprex
Copy link
Contributor Author

serprex commented Jul 23, 2024

@westy92 that PR doesn't include adding ring/aws-lc-rs features now that rustls made their crypto backend configurable. Setting features = [] on rustls will run into problems if application using mysql_async lacks another dependency to same version of rustls setting which backend to include

@sorokya
Copy link

sorokya commented Aug 15, 2024

@westy92 that PR doesn't include adding ring/aws-lc-rs features now that rustls made their crypto backend configurable. Setting features = [] on rustls will run into problems if application using mysql_async lacks another dependency to same version of rustls setting which backend to include

I'd love the feature flag to have rustls with ring as an option. I was getting build errors in CI with the latest version because of the missing dependencies required for aws-lc-rs and had to revert to 0.34.1

serprex added a commit to PeerDB-io/peerdb that referenced this pull request Aug 19, 2024
buf-setup-action deprecated in favor of buf-action

mysql_async held back from breaking minor version upgrade,
they need to address blackbeam/mysql_async#304
josephjohncox pushed a commit to josephjohncox/peerdb that referenced this pull request Aug 19, 2024
buf-setup-action deprecated in favor of buf-action

mysql_async held back from breaking minor version upgrade,
they need to address blackbeam/mysql_async#304
@serprex serprex changed the title Update rustls rustls: features guide backend Oct 7, 2024
@serprex
Copy link
Contributor Author

serprex commented Nov 6, 2024

@blackbeam ping in case this has flown under your radar

@serprex serprex force-pushed the update-rustls branch 2 times, most recently from 6f936dc to 3e8868f Compare November 11, 2024 15:30
rustls replaced ring with aws-lc-rs as default crypto backend,
expose features to select between the two, along with a feature on whether to enable tls 1.2
@blackbeam blackbeam merged commit 6c61bf9 into blackbeam:master Nov 12, 2024
13 of 15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants