Add new property for Nuget Artifacts Path #1355
Merged
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrian-sevastyanov
approved these changes
Feb 6, 2025
cpottsbd
requested changes
Feb 6, 2025
| public static final NullablePathProperty DETECT_NUGET_ARTIFACTS_PATH = | ||
| NullablePathProperty.newBuilder("detect.nuget.artifacts.path") | ||
| .setInfo("Nuget Artifacts Path", DetectPropertyFromVersion.VERSION_10_3_0) | ||
| .setHelp("The path to the build artifacts of the nuget project if not stored on regular path. i.e the path to the output of obj directory if not stored on the default path.") |
There was a problem hiding this comment.
Suggestion for condensing the help message. (Which hopefully still makes sense. ; ) )
"The path to the obj directory build artifacts of the NuGet project, if not the default path."
gopannabd
reviewed
Feb 6, 2025
| @@ -42,6 +42,9 @@ public static List<String> fromInspectorOptions(NugetInspectorOptions nugetInspe | |||
| options.add("--excluded_dependency_types=" + toCommaSeparatedStringSet(nugetInspectorOptions.getNugetExcludedDependencyTypes())); | |||
| } | |||
|
|
|||
| nugetInspectorOptions.getNugetArtifactsPath() | |||
| .ifPresent(arg -> options.add("--artifacts_path=" + arg.toString())); | |||
There was a problem hiding this comment.
Replace artifact name with nugetArtifactsPath or nuget.artifacts.path.
gopannabd
approved these changes
Feb 6, 2025
cpottsbd
approved these changes
Feb 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding a new property for the artifacts path in nuget inspector as part of enhancement did in the corresponding PR: blackducksoftware/detect-nuget-inspector#26