Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

small glitch #88

Closed
leapfog opened this issue Feb 8, 2023 · 4 comments · Fixed by #89
Closed

small glitch #88

leapfog opened this issue Feb 8, 2023 · 4 comments · Fixed by #89
Milestone
0.3.10

Comments

@leapfog
Copy link

leapfog commented Feb 8, 2023

When in diff-mode, toggling the title line isn't perfect: a single character isn't cleared.
I can trigger it with any of these commands (i.e. run them and than press t).

$ hwatch -d date +%R
$ hwatch -d echo test
$ hwatch -d echo {0..9}
$ hwatch -d echo {a..z} {A..Z}

The last one needs a small enough terminal width, for example 80 chars.
@leapfog
Copy link
Author

leapfog commented Feb 8, 2023

There is another (similar?) issue when running hwatch date +%T and press 2 (for Line-Diff) and 1 (for Watch-Diff).

zaidhaan added a commit to zaidhaan/hwatch that referenced this issue Feb 19, 2023
@zaidhaan
Watch diff: fix display: change space from delete to nbsp
90c5790 
Changes the space character used for padding and as a last
character from the delete character (U+007F) to nbsp (U+00A0).

The delete character causes some issues when appended as the last
character by in the Watch diff mode (the last character from the
date is seen), changing the space character to a nbsp fixes this.

Fixes blacknon#88.
@zaidhaan zaidhaan mentioned this issue Feb 19, 2023
Merged
@leapfog
Copy link
Author

leapfog commented Feb 21, 2023

as far as I can tell, zaidhaan's PR fixes all observed issues

@blacknon
Copy link
Owner

blacknon commented Apr 7, 2023

Sorry for the late confirmation.
I will respond in early April.

@blacknon blacknon added this to the 0.3.10 milestone Apr 14, 2023
@blacknon
Copy link
Owner

Marge in version 0.3.10. Close.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.10
Development

Successfully merging a pull request may close this issue.

Watch diff: fix display: change space from delete to nbsp zaidhaan/hwatch
2 participants
@blacknon @leapfog