Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: Task Deletion does not work properly #128

Closed
blahosyl opened this issue Aug 14, 2024 · 3 comments
Closed

BUG: Task Deletion does not work properly #128

blahosyl opened this issue Aug 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working e: manage tasks Epic: Manage tasks p: must have Priority: Part of the MVP tutoring Consulted tutoring on this issue

Comments

@blahosyl
Copy link
Owner

blahosyl commented Aug 14, 2024

The Confirm button on the modal has to be pressed twice, and the page is not refreshed. This happens both in Kanban and List views, although not always

Screen.Recording.2024-08-14.at.03.11.47.mov
@blahosyl blahosyl self-assigned this Aug 14, 2024
@blahosyl blahosyl moved this to Todo in Task Manager Aug 14, 2024
@blahosyl blahosyl added this to the Sprint 3: UX & styling milestone Aug 14, 2024
@blahosyl blahosyl added bug Something isn't working p: must have Priority: Part of the MVP e: manage tasks Epic: Manage tasks labels Aug 14, 2024
@blahosyl blahosyl changed the title BUG: Task Deletion does not work from Kanban board BUG: Task Deletion does not work properly Aug 14, 2024
@blahosyl
Copy link
Owner Author

blahosyl commented Aug 14, 2024

It works when Kanban or List is rendered without Tabs, so the issue seems to be with TaskTabs.

This could be connected to #124

blahosyl added a commit that referenced this issue Aug 14, 2024
@blahosyl
Copy link
Owner Author

blahosyl commented Aug 14, 2024

After the Delete button is clicked on the modal, the tasks is deleted, as can be seen in the Admin panel.

Proposed remediation for hiding the modal: move const [showDeleteModal, setShowDeleteModal] = useState(false); to the parent or grandparent component and pass it down as props.

Only moving this part to the parent TaskList causes a black screen when the modal pops up, as well as a 403 (Forbidden) error:

Image

@blahosyl blahosyl added the tutoring Consulted tutoring on this issue label Aug 14, 2024
blahosyl added a commit that referenced this issue Aug 14, 2024
code chages in `Task.js` suggested my tutor Roman
blahosyl added a commit that referenced this issue Aug 14, 2024
reroll all changes to TaskList
@blahosyl
Copy link
Owner Author

With the help of the addition to Task.js that tutor Roman suggested (c5f7154), this issue could be solved.

@github-project-automation github-project-automation bot moved this from In Progress to Done/Won't do in Task Manager Aug 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working e: manage tasks Epic: Manage tasks p: must have Priority: Part of the MVP tutoring Consulted tutoring on this issue
Projects
Status: Done/Won't do
Development

No branches or pull requests

1 participant