Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BUG: non-breaking warning re ProfileEdit Form #83

Closed
blahosyl opened this issue Aug 5, 2024 · 0 comments
Closed

BUG: non-breaking warning re ProfileEdit Form #83

blahosyl opened this issue Aug 5, 2024 · 0 comments
Labels
bug Something isn't working p: could have Priority: Nice to have
Milestone
Sprint 2: CRUD & ...

Comments

@blahosyl
Copy link
Owner

blahosyl commented Aug 5, 2024 •
edited
Loading

The functionality works as intended, but the console shows the following warning (also present in the Moments walkthrough project):

"Can't perform a React state update on an unmounted component"

Image

Solution

Spencer Barriball kindly provided a suggestion to write a cleanup function at the end of handleMount()
@blahosyl blahosyl added this to the Sprint 2: Profiles & UX milestone Aug 5, 2024
@blahosyl blahosyl moved this to Todo in Task Manager Aug 5, 2024
@blahosyl blahosyl added bug Something isn't working p: should have Priority: High value but not crucial p: could have Priority: Nice to have and removed p: should have Priority: High value but not crucial labels Aug 5, 2024
blahosyl added a commit that referenced this issue Aug 9, 2024
@blahosyl
add cleanup function to ProfileEditForm #83
605fb17 
code suggestion by Spencer Barriball
https://code-institute-room.slack.com/archives/C02MTH5MBDG/p1723141476108919?thread_ts=1723121474.717569&cid=C02MTH5MBDG
@blahosyl blahosyl moved this from In Progress to Done in Task Manager Aug 9, 2024
@blahosyl blahosyl closed this as completed by moving to Done in Task Manager Aug 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working p: could have Priority: Nice to have
Projects
Task Manager
Status: Done/Won't do
Milestone
Sprint 2: CRUD & basic views
Development

No branches or pull requests
1 participant
@blahosyl