-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
MB-58901: BM25 related constructs and API changes #59
Conversation
indexing_options.go
Outdated
const DefaultSimilarityModel = BM25Similarity | ||
|
||
// Supported similarity models | ||
var SupportedSimilarityModels = map[string]struct{}{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this SupportedScoringModels
or algorithms perhaps.
indexing_options.go
Outdated
@@ -24,6 +24,23 @@ const ( | |||
SkipFreqNorm | |||
) | |||
|
|||
const ( | |||
BM25Similarity = "bm25" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace Similarity with Scoring here and below.
indexing_options.go
Outdated
// similarity model just means the scoring mechanism used to rank documents fetched | ||
// for a query performed on a field. Default is the bm25 scoring but can be set | ||
// to other models like the legacy tf-idf. | ||
const DefaultSimilarityModel = BM25Similarity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default to TfIdfScoring
?
No description provided.