Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MB-58901: BM25 related constructs and API changes #59

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Conversation

Thejas-bhat
Copy link
Member

No description provided.

@Thejas-bhat Thejas-bhat changed the title BM25: fieldDict to support cardinality API MB-58901: BM25 related constructs and API changes Jan 6, 2025
@Thejas-bhat Thejas-bhat marked this pull request as ready for review January 6, 2025 11:49
const DefaultSimilarityModel = BM25Similarity

// Supported similarity models
var SupportedSimilarityModels = map[string]struct{}{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call this SupportedScoringModels or algorithms perhaps.

@@ -24,6 +24,23 @@ const (
SkipFreqNorm
)

const (
BM25Similarity = "bm25"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace Similarity with Scoring here and below.

// similarity model just means the scoring mechanism used to rank documents fetched
// for a query performed on a field. Default is the bm25 scoring but can be set
// to other models like the legacy tf-idf.
const DefaultSimilarityModel = BM25Similarity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default to TfIdfScoring ?

indexing_options.go Outdated Show resolved Hide resolved
abhinavdangeti
abhinavdangeti previously approved these changes Jan 7, 2025
@abhinavdangeti abhinavdangeti merged commit f54d76f into master Jan 7, 2025
9 checks passed
@abhinavdangeti abhinavdangeti deleted the bm25 branch January 7, 2025 15:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants