Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(@blindnet-demos/devkit-simple-tutorial): base url #84

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

nweldev
Copy link

@nweldev nweldev commented Sep 1, 2022

update the base href, related web-dev-server configuration, and links in the application to make it work with our current CD environment (https://blindnet-io.github.io/privacy-components-web/demos/devkit-simple-tutorial/)

set application base href to the one we use on CD, as we deliver all
demos in a `demos/` subdirectory
@nweldev nweldev marked this pull request as ready for review September 2, 2022 10:31
Copy link
Collaborator

@jboileau99 jboileau99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants