Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix publication of x86_64 wheels #578

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

godlygeek
Copy link
Contributor

This was broken when we added support for building manylinux2010 wheels for modern Python interpreters due to a misuse of the include configuration of the GitHub Actions matrix job.

This was broken when we added support for building manylinux2010 wheels
for modern Python interpreters due to a misuse of the `include`
configuration of the GitHub Actions matrix job.

Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
@godlygeek godlygeek force-pushed the fix_x86_64_wheel_publishing branch from f6ffdd0 to f7d2e07 Compare April 10, 2024 22:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (41248ed) to head (f7d2e07).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   92.55%   92.88%   +0.32%     
==========================================
  Files          91       91              
  Lines       11304    11195     -109     
  Branches     1581     2047     +466     
==========================================
- Hits        10462    10398      -64     
+ Misses        837      797      -40     
+ Partials        5        0       -5     
Flag Coverage Δ
cpp 92.88% <ø> (+6.94%) ⬆️
python_and_cython 92.88% <ø> (-2.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablogsal pablogsal merged commit 79de83e into bloomberg:main Apr 11, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants