-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adapt to textual 0.88.0 #698
Conversation
Note that Textualize/textual#5284 may still be a bug |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
==========================================
- Coverage 92.93% 92.87% -0.07%
==========================================
Files 95 95
Lines 11655 11655
Branches 406 406
==========================================
- Hits 10832 10824 -8
- Misses 823 831 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 23 out of 23 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
tests/unit/test_tui_reporter.py:144
- Ensure that the change from widget.render() to widget.renderable is covered by tests to verify the behavior remains correct.
rprint(widget.renderable, file=output)
28e31ca
to
85087fc
Compare
tests/conftest.py
Outdated
@@ -5,7 +5,7 @@ | |||
from packaging import version | |||
|
|||
SNAPSHOT_MINIMUM_VERSIONS = { | |||
"textual": "0.81", | |||
"textual": "0.87.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this to whatever version their next release is (either 0.88.0 or 0.87.2), since we know these tests don't pass with 0.87.1 (they need a release that contains Textualize/textual#5296 to pass)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to land as soon as Textual cuts a release that contains Textualize/textual#5296
Once they do, we should bump our SNAPSHOT_MINIMUM_VERSIONS
to match their new version number, and then this PR should pass and we can rebase the others that have gotten blocked behind the failing CI.
85087fc
to
e264c45
Compare
The new Textual release has some changes: * We need to change how our tests get the rendered version of some Textual objects as now `render()` returns `RichVisual` instances. * Textual has a new theme so we need to regenerate our snapshots. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
e264c45
to
46248f0
Compare
The new textual release has some changes:
of some textual objects as now render() returns RichVisual instances
opened Horizontal scroll bar disappeared in 0.87.1 Textualize/textual#5284 but looks
like this may be expected.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.