Expose Build options publically #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to use the windows version of the socket, I could not build with the options. This was an error where only the *Nix version had public fields to edit. To fix this, the build options has been promoted to the root of the crate, so it is used on both systems and they end up with the same config. This commit also adds an example on the mdns test to ensure it compiles using the public methods available on all platforms. It also changes the defaults of build options to listen to multicast messages, as it is very common to have multiple processes listening on the same pc.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the windows version of the socket, I could not build
with the options.
This was an error where only the *Nix version had public fields to edit.
To fix this, the build options has been promoted to the root of the
crate, so it is used on both systems and they end up with the same
config.
This commit also adds an example on the mdns test to ensure it compiles
using the public methods available on all platforms.
It also changes the defaults of build options to listen to multicast
messages, as it is very common to have multiple processes listening on
the same pc.