Delete unreachable default clauses.
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dart analyzer will soon be changed so that if the `default` clause of a `switch` statement is determined to be unreachable by the exhaustiveness checker, a new warning of type `unreachable_switch_default` will be issued. This parallels the behavior of the existing `unreachable_switch_case` warning, which is issued whenever a `case` clause of a `switch` statement is determined to be unreachable. For details see dart-lang/sdk#54575. This PR deletes unreachable `default` clauses from `photo_view` now, to avoid a spurious warning when the analyzer change lands.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart analyzer will soon be changed so that if the
defaultclause of aswitchstatement is determined to be unreachable by the exhaustiveness checker, a new warning of typeunreachable_switch_defaultwill be issued. This parallels the behavior of the existingunreachable_switch_casewarning, which is issued whenever acaseclause of aswitchstatement is determined to be unreachable. For details seedart-lang/sdk#54575.
This PR deletes unreachable
defaultclauses fromphoto_viewnow, to avoid a spurious warning when the analyzer change lands.