CTB modal disabling body scroll on second open

[wpalani]

Proposed changes

Properly set and unset 'noscroll' class to body on CTB modal open/close.

Type of Change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[circlecube]

Nice fix Al Ani, I hadn't noticed you'd fixed this already. I had done basically the same thing, but I moved these classList adjustments closer to where the modal opens and closes.

I haven't yet tested this on a live site to make sure it fixes the issue though.

[circlecube]

Just tested, and this doens't seem to fix it still - especially if we open the modal and close it real quick. Can dig in more tomorrow.

[wpalani]

Just tested, and this doens't seem to fix it still - especially if we open the modal and close it real quick. Can dig in more tomorrow.

Hey Evan, I was getting inconsistent results until I purged the cache, could that be it?
https://www.berrycast.com/conversations/69beed89-8358-5d5f-988e-08085421316a