-
Notifications
You must be signed in to change notification settings - Fork 25
Feature - eCommerce #174
Feature - eCommerce #174
Conversation
package.json
Outdated
@@ -13,6 +13,7 @@ | |||
"author": "David Ryan <dryanpress@chat.wordpress.org>", | |||
"license": "GPL-2.0-or-later", | |||
"dependencies": { | |||
"@newfold-labs/wp-module-ecommerce": "newfold-labs/wp-module-ecommerce#v0.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is this dependency referencing? I see the module package.json points to dist/index.js
(https://github.com/newfold-labs/wp-module-ecommerce/blob/trunk/package.json#L7), but that doesn't exist in the repo and I don't see any packages released (https://github.com/newfold-labs/wp-module-ecommerce/packages).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm lets you specify git sources as package url. You can refer to the npm install documentation for more details.
npm does the following things for the given package
"@newfold-labs/wp-module-ecommerce": "newfold-labs/wp-module-ecommerce#v0.2.0"
- Search for newfold-labs/wp-module-ecommerce repo on GitHub
- Check if repo has a commit ref or tag with the value
v0.2.0
- Download code from that commit
- Check if downloaded
package.json
file has aprepare
script. - Trigger the
prepare
script - Clean up remaining files based on what
files
targets inpackage.json
In our case, the prepare
script triggers the commands to produce the dist/
folder which contains the needed build artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aulisius I've created a new feature/e-commerce branch in the main Bluehost repo. I've already merged the latest version of master into that branch. Since we've recently updated to a new version of React Router DOM, there may be an issue with the e-commerce onboarding page not loading (I couldn't see any of the new functionality except the "Site Status" in the admin bar).
So, here are a few things to do:
- Convert this PR to a draft
- Pull down the latest changes from the Bluehost
feature/ecommerce
branch to your localfeature/ecommerce
branch. - Update your PR to merge into the Bluehost
feature/ecommerce
branch instead ofmaster
. - Look into why the e-commerce onboarding page isn't displaying
- Update the README.md to include what steps are required to trigger the e-commerce onboarding flow from a development perspective. For example, making sure the install date is a particular value, the database information for plan type is set, etc.
- Update the DTS build to use wp-scripts
- Address any remaining TODOs in the code (I'm seeing this)
- Tag a new release of the e-commerce module once you're done making changes
- Update the e-commerce module version in the Bluehost plugin
- Move this PR from draft to ready for review
@wpscholar regarding |
@aulisius Correct. Here is the documentation for wp-scripts: https://developer.wordpress.org/block-editor/reference-guides/packages/packages-scripts/ |
Proposed changes
This adds the eCommerce module to the plugin. Users of the plugin who are the on the eCommerce plans will be redirected to the new dashboard instead of the current
/home/onboarding
screens.Type of Change
Checklist
Pending Items