Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RTSP server not replying to OPTIONS request #8

Closed
ciuncan opened this issue Oct 16, 2020 · 1 comment
Closed

RTSP server not replying to OPTIONS request #8

ciuncan opened this issue Oct 16, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@ciuncan
Copy link
Contributor

ciuncan commented Oct 16, 2020

One of the cameras that we connect to using RTSP protocol was hanging indefinitely and causing a timeout. Looking at the Wireshark captures, we saw that the TCP connection was successfully established and afterwards the OPTIONS RTSP request was also ACK'ed, but server wasn't replying to the OPTIONS request. After comparing the packet captures with ffprobe, we saw that OPTIONS request was being sent to path / with gortsplib but ffprobe was sending it to the actual camera path /stream24&channel0.

In the RFC-7826, it says:

The URI in an OPTIONS request determines the scope of the request and the corresponding response.

I checked the code and found that in connclient.go#L359 Path field of URL object used in OPTIONS request was set to "/" instead of being set to u.Path.

Is there a specific reason to this? If not I can send a PR to fix it.

@aler9 aler9 added the bug Something isn't working label Oct 16, 2020
aler9 added a commit to ciuncan/gortsplib that referenced this issue Oct 16, 2020
aler9 added a commit to ciuncan/gortsplib that referenced this issue Oct 16, 2020
@aler9 aler9 closed this as completed in 4dae994 Oct 16, 2020
aler9 added a commit that referenced this issue Oct 16, 2020
Fix #8 - Do options request to resource path rather than /
aler9 added a commit to bluenviron/mediamtx that referenced this issue Oct 16, 2020
@github-actions
Copy link

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants