Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Empty directories are not being deleted as expected after fix recordDeleteAfter #4227

Closed
anktx opened this issue Feb 6, 2025 · 2 comments · Fixed by #4231
Closed

Empty directories are not being deleted as expected after fix recordDeleteAfter #4227

anktx opened this issue Feb 6, 2025 · 2 comments · Fixed by #4231
Labels
bug Something isn't working record playback

Comments

@anktx
Copy link

anktx commented Feb 6, 2025

Which version are you using?

1.11.2

Which operating system are you using?

Linux amd64 standard, Linux amd64 Docker

Describe how to replicate the issue

Hi Team,

After the bug related to the recordDeleteAfter parameter was fixed (see #3557), I've noticed that while recordings are being handled correctly, empty directories are not being deleted after the recordings are removed. This behavior persists even with the updated version.

Could you please look into this? It seems like the cleanup process doesn't account for empty directories, which still remain on the filesystem.

Thank you for your time!

Server logs

No response

Network dump

No response
@aler9 aler9 added bug Something isn't working record playback labels Feb 7, 2025
aler9 added a commit that referenced this issue Feb 7, 2025
@aler9
fix removing empty recording folders (#4227)
b4aa8a9
@aler9 aler9 mentioned this issue Feb 7, 2025
Merged
@aler9
Copy link
Member

aler9 commented Feb 7, 2025

Thanks for reporting the issue, this is fixed by #4231

aler9 added a commit that referenced this issue Feb 7, 2025
@aler9
fix removing empty recording folders (#4227)
57011f1
aler9 added a commit that referenced this issue Feb 7, 2025
@aler9
fix removing empty recording folders (#4227) (#4231)
d31f1ab
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This issue is mentioned in release v1.11.3 🚀
Check out the entire changelog by clicking here

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working record playback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix removing empty recording folders (#4227) bluenviron/mediamtx
2 participants
@anktx @aler9