Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RunOn.. commands - Propagate errors in restart configurations #2828

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

jsbohnert
Copy link
Contributor

The RunOn{Init,Ready, etc} commands call back with a generic 'exited with code 0' message if the command is specified with its relevant 'Restart' option set to 'yes'. eg

runOnInit command exited: command exited with code 0

This PR allows underlying err result to actually be seen in logs, eg

runOnInit command exited: exec: "ffmpeg": executable file not found in %PATH%

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6fec31) 57.35% compared to head (6b9a3f4) 57.35%.
Report is 1 commits behind head on main.

❗ Current head 6b9a3f4 differs from pull request most recent head 765873e. Consider uploading reports for the commit 765873e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2828   +/-   ##
=======================================
  Coverage   57.35%   57.35%           
=======================================
  Files         125      125           
  Lines       11517    11517           
=======================================
  Hits         6605     6605           
  Misses       4404     4404           
  Partials      508      508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 3ecd79f into bluenviron:main Dec 26, 2023
6 checks passed
@aler9
Copy link
Member

aler9 commented Dec 26, 2023

i applied gofmt and merged, thanks!

Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue is mentioned in release v1.4.2 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants