-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix DELETE URL problem #3195
Fix DELETE URL problem #3195
Conversation
This PR addresses a problem with DELETE (missing FQDN, discussed here #3177) and fixes some CORS issues, which prevented this client to operate properly in trickle-ICE mode https://github.com/Eyevinn/whip
Added NGINX detection in order to provide the proper scheme
An even easier approach to solve this problem after discussion
I tested both Eyevinn/whip client (https://web.whip.eyevinn.technology/) and OBS 30.1.2, against MediaMTX v1.6.0 and MediaMTX. All combination worked without changing any header. Changes in this PR are not needed. |
I'm sorry, we must be talking about different versions. I'm here at commit f5d9fde of your repo, Aril 1st. This is the response given to OBS 30.1.2 on MacOS for a DELETE with the URL, which is (still) relative and by that not working for OBS (and others): The location header given in the 201 was:
It would work if it would be '/stream/whip/0ab307c5-870d-4eab-8cba-037a0d97d7a3' What am I missing? You could have changed that meanwhile, that would explain it. I didn't pull for a while... |
I had a lengthy chat with Eyevinn last week regarding missing CORS headers, but feel free to ignore. I'm not using their solution. |
This issue is mentioned in release v1.7.0 🚀 |
This PR addresses a problem with DELETE (missing FQDN, discussed here #3177) and fixes some CORS issues, which prevented this client to operate properly in trickle-ICE mode https://github.com/Eyevinn/whip