Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

api: fix crash when changing settings of an on-demand source that is idle (#3246) #3249

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 15, 2024

Fixes #3246

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 54.74%. Comparing base (1c135fb) to head (ade077f).

Files Patch % Lines
internal/core/static_source_handler.go 0.00% 8 Missing ⚠️
internal/core/path.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3249      +/-   ##
==========================================
- Coverage   54.78%   54.74%   -0.05%     
==========================================
  Files         153      153              
  Lines       18282    18288       +6     
==========================================
- Hits        10016    10011       -5     
- Misses       7450     7461      +11     
  Partials      816      816              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 95f1f79 into main Apr 15, 2024
7 of 9 checks passed
@aler9 aler9 deleted the fix/on-demand-api branch April 15, 2024 15:44
Copy link
Contributor

This issue is mentioned in release v1.8.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MediaMTX crashes after enabling recording on path with source on demand
1 participant