Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix crash when recording a stream with unsupported tracks (#3978) #3996

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 30, 2024

Fixes #3978

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 81.45695% with 28 lines in your changes missing coverage. Please review.

Project coverage is 55.99%. Comparing base (bdc051c) to head (f024671).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/recorder/format_fmp4.go 54.28% 16 Missing ⚠️
internal/recorder/format_mpegts.go 60.71% 11 Missing ⚠️
internal/recorder/recorder.go 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
+ Coverage   55.94%   55.99%   +0.05%     
==========================================
  Files         194      194              
  Lines       19583    19593      +10     
==========================================
+ Hits        10956    10972      +16     
+ Misses       7786     7782       -4     
+ Partials      841      839       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit b77df43 into main Nov 30, 2024
8 checks passed
@aler9 aler9 deleted the fix/record-crash branch November 30, 2024 10:23
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This issue is mentioned in release v1.10.0 🚀
Check out the entire changelog by clicking here

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rtsp and vp8: segmentation violation code=0x1 addr=0x30 pc=0x6a4af0]
1 participant