Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

webrtxc: fix MTX_QUERY not set when reading or publishing (#4138) (#3937) #4141

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jan 11, 2025

Fixes #4138
Fixes #3937

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 77.38693% with 45 lines in your changes missing coverage. Please review.

Project coverage is 56.47%. Comparing base (5077fb2) to head (712b0dc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/defs/path_access_request.go 29.26% 27 Missing and 2 partials ⚠️
internal/auth/request.go 70.00% 6 Missing and 3 partials ⚠️
internal/metrics/metrics.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4141      +/-   ##
==========================================
+ Coverage   56.27%   56.47%   +0.20%     
==========================================
  Files         199      202       +3     
  Lines       20574    20644      +70     
==========================================
+ Hits        11578    11659      +81     
+ Misses       8128     8117      -11     
  Partials      868      868              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the fix/webrtx-mtx-query branch from cc13106 to f44032e Compare January 11, 2025 16:19
@aler9 aler9 force-pushed the fix/webrtx-mtx-query branch from f44032e to 712b0dc Compare January 11, 2025 16:21
@aler9 aler9 merged commit 8f04264 into main Jan 11, 2025
8 checks passed
@aler9 aler9 deleted the fix/webrtx-mtx-query branch January 11, 2025 16:29
Copy link
Contributor

This issue is mentioned in release v1.11.1 🚀
Check out the entire changelog by clicking here

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant