Implement new UI to Configurations - Telemetry #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
…ions Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
rafaellehmkuhl
requested changes
Jun 24, 2024
src/components/GlassModal.vue
Outdated
Comment on lines
28
to
31
| */ | ||
| position?: ModalPosition | ||
| /** | ||
| * |
There was a problem hiding this comment.
An explanation about what those props do would be helpful.
ArturoManzoli
force-pushed
the
972-Implement-Configuration-Logs
branch
from
f22b340 to
f219ac5
Compare
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
ArturoManzoli
force-pushed
the
972-Implement-Configuration-Logs
branch
from
f219ac5 to
c1812bd
Compare
rafaellehmkuhl
approved these changes
Jun 25, 2024
rafaellehmkuhl
merged commit 2e0f4e2
into
bluerobotics:interface-rework
8 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same UI philosophy implemented on #969