-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow multiple snackbars to stack up on screen #1687
Allow multiple snackbars to stack up on screen #1687
Conversation
I'm testing here and it's apparently working perfectly! Nice update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: can we also make the closeButton
default to true
? I think it should be already, but it has even more value now that closing can make space for other snackbars.
6638fe8
to
38a6d07
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update!
Since the only thing I asked to be changed is a minor, I'm considering it approved and you can just push the change and merge.
src/components/Snackbar.vue
Outdated
onMounted(() => { | ||
console.debug('Snackbar message:', textMessage.value) | ||
}) | ||
onMounted((): void => console.debug('Snackbar message:', props.message)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment that was supposed to be here was that it would help a lot with the system logs if we use the console level that matches the variant of the snackbar (e.g.: variant=error -> console.error).
Haven’t tested yet, but just checking, is there a limit on how high they can go, or can they end up going over the top bar / off the screen? |
…plement its use on related files Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
…de components Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
38a6d07
to
bf3b607
Compare
They will overshoot the screen height, but since there is a default timer, soon the pile will reduce |
Screenshare.-.2025-02-12.10_42_08.AM.mp4
Closes #1227