Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow multiple snackbars to stack up on screen #1687

Merged

Conversation

ArturoManzoli
Copy link
Contributor

  • Now multiple snackbars will stack on top of each other instead of overlaying;
Screenshare.-.2025-02-12.10_42_08.AM.mp4

Closes #1227

@rafaellehmkuhl
Copy link
Member

I'm testing here and it's apparently working perfectly! Nice update!

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: can we also make the closeButton default to true? I think it should be already, but it has even more value now that closing can make space for other snackbars.

@ArturoManzoli ArturoManzoli force-pushed the 1227-snackbars-should-stack-up branch from 6638fe8 to 38a6d07 Compare February 12, 2025 20:44
@ArturoManzoli
Copy link
Contributor Author

Suggestion: can we also make the closeButton default to true? I think it should be already, but it has even more value now that closing can make space for other snackbars.

Done!

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update!

Since the only thing I asked to be changed is a minor, I'm considering it approved and you can just push the change and merge.

Comment on lines 90 to 77
onMounted(() => {
console.debug('Snackbar message:', textMessage.value)
})
onMounted((): void => console.debug('Snackbar message:', props.message))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment that was supposed to be here was that it would help a lot with the system logs if we use the console level that matches the variant of the snackbar (e.g.: variant=error -> console.error).

@ES-Alexander
Copy link
Contributor

Haven’t tested yet, but just checking, is there a limit on how high they can go, or can they end up going over the top bar / off the screen?

…plement its use on related files

Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
…de components

Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
@ArturoManzoli ArturoManzoli force-pushed the 1227-snackbars-should-stack-up branch from 38a6d07 to bf3b607 Compare February 13, 2025 13:03
@ArturoManzoli
Copy link
Contributor Author

Haven’t tested yet, but just checking, is there a limit on how high they can go, or can they end up going over the top bar / off the screen?

They will overshoot the screen height, but since there is a default timer, soon the pile will reduce

@ArturoManzoli ArturoManzoli merged commit e01dc58 into bluerobotics:master Feb 13, 2025
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snackbars should stack up
3 participants