Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

src: components: InputElementConfig.vue: clarify Action language #1691

Conversation

ES-Alexander
Copy link
Contributor

I didn't get a chance to review #1688, so here's my main suggested change.

For context, "existent" is rarely used in English, and it seems more intuitive to have buttons be verbs (since clicking a button should do something) :-)

"Existent" is rarely used in English, and it seems more intuitive to have buttons be verbs (since clicking a button should do something)
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@ES-Alexander ES-Alexander merged commit e5af6bf into bluerobotics:master Feb 13, 2025
11 checks passed
@ES-Alexander ES-Alexander deleted the clarify-input-widget-action-language branch February 13, 2025 21:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants