Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix missing dependencies #9

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix missing dependencies #9

merged 1 commit into from
May 11, 2023

Conversation

aliceisjustplaying
Copy link
Contributor

We're using @atproto/lexicon and multiformats but it's not in package.json. This is fine for npm and yarn (classic) but pnpm and yarn berry are much more strict and will complain loudly and refuse to start. This fixes that. (also updates @types/node to the latest version)

@aliceisjustplaying aliceisjustplaying changed the title Fix dependencies Fix missing dependencies May 11, 2023
dholms
dholms approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent. thank you!

@dholms dholms merged commit f9ccf11 into bluesky-social:main May 11, 2023
@aliceisjustplaying aliceisjustplaying deleted the fix-deps branch May 11, 2023 19:50
haileyok pushed a commit that referenced this pull request Oct 31, 2024
@aliceisjustplaying
fix dependencies (#9)
443887b
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dholms dholms dholms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliceisjustplaying @dholms