[APP-1049] show label expiration in frontend #7738
Conversation
arcalinea
temporarily deployed
to
eric/app-1049-show-label-expiration-in-frontend - social-app PR #7738
Render
Destroyed
| let source = labeler | ||
| ? sanitizeHandle(labeler.creator.handle, '@') | ||
| : undefined | ||
| let sourceDisplayName = labeler?.creator.displayName | ||
| if (!source) { | ||
| if (cause.label.src === BSKY_LABELER_DID) { | ||
| source = 'Bluesky Moderation Service' | ||
| source = 'moderation.bsky.app' | ||
| sourceDisplayName = 'Bluesky Moderation Service' | ||
| } else { | ||
| source = cause.label.src | ||
| source = _(msg`an unknown labeler`) | ||
| } |
There was a problem hiding this comment.
Now prioritizes the handle over the display name
| const sourceName = | ||
| desc.source || desc.sourceDisplayName || _(msg`an unknown labeler`) |
There was a problem hiding this comment.
Source will always be defined based on the logic in useModerationCauseDescription, but did this for completeness
|
estrattonbailey
force-pushed
the
eric/app-1049-show-label-expiration-in-frontend
branch
from
7aeb225 to
14fe841
Compare
| . | ||
| </Trans> | ||
| </Text> | ||
| <View style={[a.flex_row, a.justify_between, a.gap_xl]}> |
There was a problem hiding this comment.
Visual alignment is a little off, would look better with +4px padding on the bottom
There was a problem hiding this comment.
Yeah common problem with aligning text: it's aligned to the line-height, basically the capital letters. Aligning to the x-height isn't a good option either because then capitals look off too, but we can pry fudge it with a number in between that makes it feel a little better.
There was a problem hiding this comment.
Yeah anything more than 1px starts to look wrong to me, esp when there's not exp shown and it's just Source: .... Copied this fix to LabelsOnMe as well since it's the same treatment there.
arcalinea
temporarily deployed
to
eric/app-1049-show-label-expiration-in-frontend - social-app PR #7738
Render
Destroyed
Show's label expiration (if set) on labels, for both the labeled user and viewers.
I also opted to align the UI a bit here from where it was, since I think the
LabelsOnMedialog treatment is more attractive and succinct, and works well for the expiry handling.Also,
useGetTimeAgois really just a date diff, so tbh we could rename that to make it more obvious that it can be used for future dates too.We should really build a real tooltip too for web hovers e.g. to show the precise expiry on hover.