Deploy preview #240
Merged
Deploy preview #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… import, and add dummyTeams data
All API and page components have been refactored to use Promise for params handling, according to the latest Next.Js 15 specifications
- Updated next.config.mjs to include server-side external packages, enable React strict mode, and enforce TypeScript build validation. - Modified DocumentsPage to use dynamic rendering and streamlined the list of features with a map function for better readability.
mahid797
added
Refactor
This was
linked to
issues
Feb 26, 2025
Closed
|
Please review this as soon as possible. |
parwatcodes
approved these changes
Feb 26, 2025
…ed on environment variable
**This closes #234.** **Implemented:** 1. Ran the build to identify all current build warnings in the terminal. 2. Fixed missing dependencies in React Hooks (useEffect, useCallback, useMemo). 3. Tested affected components to ensure functionality remains intact after fixes. 4. Reran the build after each set of changes to verify warnings are resolved. **Warnings before being fixed:** 1. **ContactsTable.tsx** Warning: React hook useEffect has a missing dependency. Fixed by rowHeight state ( e.g., [rowHeight] ). 2. **DocumentsTable.tsx** Warning: React hook useEffect has a missing dependency. Fixed by rowHeight state ( e.g., [rowHeight] ). 3. **DragAndDropBox.tsx** Warning: React hook useCallback has a missing dependency. Fixed by handleFileSelect function because the related function (onDrop) is effected by handleFileSelect ( e.g., [handleFileSelect] ). Then, wrapped handleFileSelect in useCallback with the related dependencies to prevent unnecessary re-creation of onDrop on every render. 4. **FileAccessContainer.tsx** Warning: React hook useEffect has a missing dependency. Fixed by toast. In fact, the useEffect hook already had linkId as a dependency, but it needed both linkId and toast because the useEffect hook should run whenever either linkId or toast changes ( e.g., [linkId, toast] ). 5. **ProfileForm.tsx** Warning: React hook useEffect has a missing dependency. In this case, we had the fetchProfileData function inside the useEffect hook, so we needed to leave the the dependency array empty. 6. **Breadcrumb.tsx** Warning: React hook useMemo has a missing dependency. Fixed by renderBreadcrumb function. In fact, the useMemo hook already had pathnames as a dependency, but it needed both pathnames and renderBreadcrumb because the useMemo hook should run whenever either pathnames or renderBreadcrumb changes ( e.g., [pathnames, renderBreadcrumb] ). Then, wrapped renderBreadcrumb in useCallback with the related dependency to prevent unnecessary re-creation of breadcrumbs on every render. 7. **CustomCircularProgress.tsx** Warning: React hook useEffect has a missing dependency. Fixed by the handleProgress seState, which was passed to the CustomCircularProgress component as a props ( e.g., [handleProgress] ).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves all build errors preventing the deployment of the project preview to Vercel. The changes include fixing TypeScript issues, cleaning up outdated code, updating core dependencies, and refactoring components and services to comply with Next.js 15 and React 19 standards. These updates ensure improved stability, maintainability, and compatibility with modern development practices. Closes #237 and #238
🔑 Changes Summary
package.jsonto the latest stable versions:api\auth\[...nextauth]\route.tsto useauthOptions.ts.react-emailusage..env.exampleto document necessary environment variables.