You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The quickest and simplest fix is by reverting changes to all start_index related logic.
However, in the long run, we should probably decouple indexing logic with Topic labels, which will then allow renaming topics, which is sometimes requested by users.
The text was updated successfully, but these errors were encountered:
I believe this is a high impact bug as it is not easy to notice, and can lead to incorrect interpretation, especially item 5.
Steps to reproduce
As of
pyldavis==3.4.1
, the bug should manifest itself as a minor UI bug (item 2,3
), and data inconsistency (item 5
).It can be reproduced as follow:
start_index=0
Blame
This commit: 010cde0#diff-12750ebcae02c096cb6939beb54d0ab2353800555b8c01b00fae4fe93f376cfd
reverted some changes that are necessary for non-zero indexing to be functional:
f1cdb65#diff-ce28a7d983569ace041957292840319d65e2c6352989ae5f5556ae555e89404d
Solutions
The quickest and simplest fix is by reverting changes to all
start_index
related logic.However, in the long run, we should probably decouple indexing logic with Topic labels, which will then allow renaming topics, which is sometimes requested by users.
The text was updated successfully, but these errors were encountered: