Workaround fix for JVM Crash Issue while refreshing 'ProblemTreeViewer' #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhargrave
requested changes
Sep 27, 2021
This workaround ensures that the action is performed on the display thread properly. However, the bug still exists in the SWT/JFace which needs to be fixed. Other plugins using `getTreeViewer().refresh()` from `PackageExplorerPart` are prone to crash the JVM as well. Fixes bndtools#4854 Signed-off-by: Amit Kumar Mondal <admin@amitinside.com>
amitjoy
force-pushed
the
fix/bug/4854/workaround-jvm-crash
branch
from
c7a7d7b to
2bfd056
Compare
|
I will cherry-pick this fix onto the next branch for the 6.0 release. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround ensures that the action is performed on the display thread properly by rescheduling it on the display thread. Note that, previously it was also executed on the display thread, but underlying SWT/JFace didn't submit the task properly to the display thread. That's why, this MR ensures that we submit the task properly (or explicitly) to the display thread. The bug still exists in the SWT/JFace which needs to be fixed. Other plugins using
getTreeViewer().refresh()fromPackageExplorerPartare prone to crash the JVM as well.Fixes #4854