feat: support modifiers proposal #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
commented
Jul 8, 2022
| if(a.type == "quantifier" && b.type == "quantifier" && a.symbol == null && b.symbol == "+"){ | ||
| b.symbol = undefined; | ||
| } | ||
|
|
There was a problem hiding this comment.
Here is the bug fix, when I updated regjsparser to 0.8.4 it failed the test.
JLHwung
approved these changes
Sep 12, 2022
nicolo-ribaudo
approved these changes
Dec 14, 2022
|
cc @bnjmnt4n if you have time for a review! |
|
Ping @bnjmnt4n :) |
|
Thanks for the PR and sorry for the delay! Will push a release asap. @nicolo-ribaudo I can add you to the repo + npm package if you'd like. Thanks as always for the awesome work on babel! |
bnjmnt4n
added a commit
that referenced
this pull request
Jun 6, 2023
- Add support for modifiers proposal (#28)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: jviereck/regjsparser#127