Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

macOS on M1 architecture: Spurious test failure on clock::with_std::test::instant_impls_coverage #114

Closed
antifuchs opened this issue Feb 11, 2022 · 0 comments · Fixed by #115
Closed

macOS on M1 architecture: Spurious test failure on clock::with_std::test::instant_impls_coverage #114

antifuchs opened this issue Feb 11, 2022 · 0 comments · Fixed by #115
Labels
bug Something isn't working

Comments

@antifuchs
Copy link
Collaborator

There is a problem in the Add impl for Instant+Duration on aarch64-apple-darwin right now: rust-lang/rust#91417; this leads to a test failure on M1 macs running macOS.

It's peaceful, but we should probably not run the test on that architecture until the bug is fixed.
@antifuchs antifuchs added the bug Something isn't working label Feb 11, 2022
@antifuchs antifuchs mentioned this issue Feb 13, 2022
Merged
@bors bors bot closed this as completed in 6eb1060 Feb 13, 2022
@antifuchs antifuchs mentioned this issue May 28, 2022
Merged
bors bot added a commit that referenced this issue May 28, 2022
@bors @antifuchs
Merge #108
9ef36f4 
108: Attempt to fix "remaining burst capacity" when time moves r=antifuchs a=antifuchs

This is a stab at addressing #102. This adds a "time of measurement" field to the StateSnapshot struct, which allows correct computation of the remaining burst capacity.

This PR was previously blocked by a mysterious test failure on my M1 mac, which I'm pretty sure was related #114. After rebasing to latest master, this passes its own tests and looks plausible enough to release.

Co-authored-by: Andreas Fuchs <asf@boinkor.net>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conditionalize-out the Instant::now test on M1 macs boinkor-net/governor
1 participant
@antifuchs