Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dont fork when all.concurrency = 1 #207

Merged
merged 1 commit into from
Feb 17, 2022
Merged

dont fork when all.concurrency = 1 #207

merged 1 commit into from
Feb 17, 2022

Conversation

tongueroo
Copy link
Contributor

@tongueroo tongueroo commented Feb 17, 2022

This is a πŸ™‹β€β™‚οΈ feature or enhancement.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

The terraspace all commands will not fork when all.concurrency <= 1. This should, in theory, allow it to work with windows, since fork is linux specific. Yes, it's a workaround.

Note: When this non-forking mode is activated terraspace all summarized logging is disabled and all the logs are streamed to the current terminal.

Context

How to Test

Try https://github.com/boltops-tools/terraspace-graph-demo with all.concurrency = 1 enabled.

Version Changes

Patch

@tongueroo tongueroo merged commit 1e871ad into master Feb 17, 2022
@tongueroo tongueroo deleted the dont-fork branch February 17, 2022 15:03
@tongueroo
Copy link
Contributor Author

Released in 1.1.3

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use fork() when concurrency is 1
1 participant