Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor image anisotropy check to handle headless execution. #313

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

mdoube
Copy link
Member

@mdoube mdoube commented Apr 12, 2022

The anisotropy check previously always showed a GUI if the image was anisotropic, but this broke headless execution. If code is called from a headless environment, e.g. a Python script, a warning is printed to the console and execution continues, even if results may be unreliable.

@mdoube mdoube requested a review from alessandrofelder April 19, 2022 05:31
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion about a comment, but otherwise looks good.

…rapperUtils/Common.java

Co-authored-by: Alessandro Felder <alessandrofelder@users.noreply.github.com>
@mdoube mdoube merged commit c828a1b into master Apr 19, 2022
@mdoube mdoube deleted the anisotropy-warning branch April 19, 2022 11:19
mdoube added a commit that referenced this pull request Apr 21, 2022
* Refactor image anisotropy check to handle headless execution.

* Update Modern/wrapperPlugins/src/main/java/org/bonej/wrapperPlugins/wrapperUtils/Common.java

Co-authored-by: Alessandro Felder <alessandrofelder@users.noreply.github.com>
mdoube added a commit that referenced this pull request Apr 5, 2024
* Refactor image anisotropy check to handle headless execution.

* Update Modern/wrapperPlugins/src/main/java/org/bonej/wrapperPlugins/wrapperUtils/Common.java

Co-authored-by: Alessandro Felder <alessandrofelder@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants