Skip to content

Commit

Permalink
fix!: pin corepack version
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This package now requires a minimum Node.js of v16.20.0.

`corepack` v0.17.0 which ships with Node.js v16 seems completely broken (at least on my machine!) so we can't rely on the version shipped with Node.js.  This adds `corepack` as a dev dependency, and since the minimum version is Node.js v16.20.0, we have to bump our minimum version as well.

This also simplifies finding the `corepack` executable.
  • Loading branch information
boneskull committed Aug 14, 2023
1 parent 91ae72a commit 20a0a03
Show file tree
Hide file tree
Showing 5 changed files with 103 additions and 81 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ It's recommended to install `midnight-smoker` as a dev dependency, if you want t

Run `npm install midnight-smoker --save-dev`.

- Node.js versions supported: `^16.13.0 || ^18.0.0 || ^20.0.0`
- Node.js versions supported: `^16.20.0 || ^18.0.0 || ^20.0.0`
- Minimum `npm` version supported: `v7.0.0`

While odd-numbered Node.js releases _may_ work, they are not tested on and not officially supported.
Expand Down
141 changes: 86 additions & 55 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
"dependencies": {
"@types/semver": "7.5.0",
"chalk": "4.1.2",
"corepack": "0.19.0",
"debug": "4.3.4",
"execa": "5.1.1",
"lilconfig": "2.1.0",
Expand Down Expand Up @@ -133,7 +134,7 @@
"unexpected-sinon": "11.1.0"
},
"engines": {
"node": "^16.13.0 || ^18.0.0 || ^20.0.0",
"node": "^16.20.0 || ^18.0.0 || ^20.0.0",
"npm": ">=7"
},
"overrides": {
Expand Down
Loading

0 comments on commit 20a0a03

Please # to comment.