Rewrite editor navigation model #1870
Conversation
glopesdev
force-pushed
the
issue-1823
branch
2 times, most recently
from
b02e6ba to
8a1b9af
Compare
|
Early feedback from the preview is that allowing opening of independent tabs and windows should be allowed in the editor control to allow watching different parts of the workflow. We could take this opportunity to generalize tabs and floating windows into a single dock panel. The main concern is going to be how to handle multiple windows pointing to the same path, and what to do when deleting group nodes causes invalidation of multiple open tabs. For the first issue we could consider enforcing that windows are singleton w.r.t. a unique path, which would obviate having to synchronize multiple view states of the same workflow. For the second issue we could probably store it in the undo/redo stack as we did in the previous navigation model by closing as a command and scheduling reopening of tab/window pointing to the deleted path with same settings in the undo command. Another option is to restrict navigation to only one window and have secondary windows used only as read-only or watch views. |
- Add workflow explorer treeview - Allow navigating to any level without opening previous levels - Allow visualizers to run uncoupled from the workflow view - Highlight build errors in explorer treeview
A specific close sequence for panes is used to maximize chances of recovering the original layout when changing themes.
glopesdev
force-pushed
the
issue-1823
branch
from
6ac8553 to
5320821
Compare
The dock panel infrastructure has a habit of temporarily keeping closed dock contents in the list. These may or may not be disposed, or in the process of disposing. Operating on disposed graph views will throw and conceptually has no benefit so we avoid updating them here.
The workflow editor control should not create tabs in the constructor. Otherwise this action will be stored in the undo stack. Instead, it should use the clear method similar to the new file menu action.
For some unfathomable reason the dock panel initialization on mono is compromised if we fail to create any dock content inside the control constructor. The stack trace is complex and after trying a variety of workarounds this simple fix eliminated all errors.
Workflow Explorer
Dock Panel
Fixes #1823
Fixes #1993
Fixes #2000
Fixes #2001
Fixes #2004