Remove internal counter from dealer socket #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
force-pushed
the
refactor-dealer
branch
from
6d6a776 to
3648c37
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in relation to issue #15 and addresses it by removing the internal counter from Dealers entirely.
A Dealer socket is expected to be used as a fully asynchronous channel between client and server, and either of them can send arbitrary message streams to each other, without any constraints on pairing requests to responses (in a way there is no concept of "request" or "response" in a dealer, only messages).
The client-server article in the updated docs provides an example of such a flexible use which depends on this change.