Extract refactorings from #952 #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
changed the title
MikaelMayer
approved these changes
Oct 3, 2024
| @@ -166,7 +167,7 @@ public HoudiniSession(Houdini houdini, VerificationConditionGenerator vcgen, Pro | |||
| collector = new VerificationResultCollector(houdini.Options); | |||
| collector.OnProgress?.Invoke("HdnVCGen", 0, 0, 0.0); | |||
|
|
|||
| vcgen.ConvertCFG2DAG(run, taskID: taskID); | |||
| new RemoveBackEdges(vcgen).ConvertCfg2Dag(run, taskID: taskId); | |||
There was a problem hiding this comment.
Nit: style and maintenance. A more discoverable IMO would be to declare a method on vcgen named "RemoveBackEdges() thar calls and return new RemoveBackEdges(this)
| @@ -18,20 +18,20 @@ void ObjectInvariant() | |||
| } | |||
|
|
|||
|
|
|||
| public CallCounterexample(VCGenOptions options, List<Block> trace, List<object> augmentedTrace, AssertRequiresCmd assertRequiresCmd, Model model, | |||
| public CallCounterexample(VCGenOptions options, List<Block> trace, List<object> augmentedTrace, AssertRequiresCmd failingAssertRequires, Model model, | |||
There was a problem hiding this comment.
Nice renaming that brings some meaning.
| } | ||
|
|
||
| blockMap[(Block) bl] = auxNewBlock; | ||
| continue; |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.