Pass correct user id in Move notification #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing the *requesting* user's moved_to value to the Move notification template, instead of the id of the user that they are being notified about. Additionally, the id_to_username template tag had no fallback for if the user_id is None. This resolves both problems and removes an unnecessary space in a template for when the logged in user made the move. Fixes bookwyrm-social#3196
mouse-reeve
reviewed
Jan 17, 2024
| @@ -125,7 +125,8 @@ def id_to_username(user_id): | |||
| name = parts[-1] | |||
| value = f"{name}@{domain}" | |||
|
|
|||
| return value | |||
| return value | |||
| return "a new user account" | |||
There was a problem hiding this comment.
I'm going to merge this since it's an active bug, but this should be localized as _("a new user account")
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing the requesting user's
moved_tovalue to the Move notification template, instead of the id of the user that they are being notified about. Additionally, theid_to_usernametemplate tag had no fallback for if theuser_id isNone.This resolves both problems and removes an unnecessary space in a template for when the logged in user made the move.
Fixes #3196