Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable user exports #3226

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

hughrun
Copy link
Contributor

@hughrun hughrun commented Jan 17, 2024

  • add setting to enable and disable user exports (defaults to False)
  • do not allow user exports when using s3 storage
  • do not serve non-image files from /images/ (requires admins to update nginx settings)
  • increase default file upload limit to 100MB to enable user exports to be imported (can be changed in .env)

Fixes #3210

- new setting to enable user exports defaults to False
- add setting to enable and disable user exports
- do not allow user exports when using s3 storage
- do not serve non-image files from /images/ (requires update to nginx settings)
- increase default file upload limit to 100MB to enable user exports to be imported (can be changed in .env)
@mouse-reeve mouse-reeve merged commit a585321 into bookwyrm-social:main Jan 17, 2024
10 checks passed
@prolibre
Copy link

Hello @hughrun It's me again
sorry, I don't mean to pester you :-)

I think there's a new variable missing in .env.example to allow (or not) export.
The variable that would correspond to user_exports_enabled

@hughrun
Copy link
Contributor Author

hughrun commented Jan 18, 2024

@prolibre it's a new value in the site settings model. You need to run ./bw-dev migrate or for dockerless I think it's python manage.py migrate

@prolibre
Copy link

@hughrun
I misspoke (because of the translation).
What variable should I put in my .env file (I don't use docker) to activate the export ? I use the .env file as a configuration file.

@hughrun
Copy link
Contributor Author

hughrun commented Jan 18, 2024

My apologies @prolibre this has not been explained properly. You do not use the .env - there is a setting in the Admin panel. Go to /settings/dashboard and then click on "Imports" in the menu. That shows various settings for book and user imports, and also now has a setting for enabling or disabling user exports. I will add an Issue to make this a bit clearer.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default DATA_UPLOAD_MAX_MEMORY_SIZE is too small for user imports
3 participants