[Fix/redis-insert]- 2글자 이하 입력 시 redis에서 error를 throw하는 에러 수정 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
crossref 탐색하는 로직이 붙다보니, 기존 테스트코드가 통과하지 못했습니다~ |
leesungbin
approved these changes
Dec 9, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
입력값을 2글자 미만인 경우를 validation pipe에서 막고 있었으나, redis검증 로직에서 2글자 이하인 경우를 에러를 내는 설계 오류가 있었습니다.
작업사항