4-6 [FE][fix] 인기검색어 클릭시 검색결과 페이지로 이동하는 방식 수정 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeynii
approved these changes
Nov 28, 2022
Comment on lines
+54
to
+59
| <Link key={data.keyword} to={createSearchQuery(data.keyword)}> | ||
| <KeywordContainer> | ||
| <KeywordIndex>{index + 1}</KeywordIndex> | ||
| <Keyword>{data.keyword}</Keyword> | ||
| </KeywordContainer> | ||
| </Link> |
There was a problem hiding this comment.
확실히 Link 컴포넌트로 감싸는 방식이 더 눈에 잘 들어오네요. 좋은 방법입니다.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
인기검색어 클릭시 검색결과 페이지로 이동하는 방식을 수정했습니다.
기존 : 각 키워드에 onClick 이벤트를 달고 click 시
navigate를 이용하여 페이지 이동수정 : 각 키워드에
Link를 적용하여 페이지 이동페이지 이동에 react-router-dom을 사용하고 있는데, navigate를 사용하는 것보다 Link 기능을 사용하는 것이 더 직관적으로 페이지 이동을 파악할 수 있고, 코드 양을 줄일 수 있다고 판단하여 수정하였습니다.
작업사항