14-3 [FE] [논문 상세 - 네트워크 차트] 검색한 논문과 이를 참조한 논문을 1depth만큼 표현하는 네트워크 그래프를 렌더링 한다. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeynii
changed the title
Palwol
approved these changes
Dec 5, 2022
Comment on lines
+18
to
+32
| const updateLinks = useCallback( | ||
| (linksSelector: SVGGElement) => { | ||
| d3.select(linksSelector) | ||
| .selectAll('line') | ||
| .data(links) | ||
| .join('line') | ||
| .attr('x1', (d) => d.source?.x) | ||
| .attr('y1', (d) => d.source?.y) | ||
| // .transition() | ||
| // .delay((d, i) => (i + 1) * 500) | ||
| .attr('x2', (d) => d.target?.x) | ||
| .attr('y2', (d) => d.target?.y); | ||
| }, | ||
| [links], | ||
| ); |
There was a problem hiding this comment.
updateLinks와 updateNodes도 useCallback으로 감싸두었으니 custom hook으로 빼도 좋을 것 같습니다.
leesungbin
approved these changes
Dec 5, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
14-3 [FE] [논문 상세 - 네트워크 차트] 검색한 논문과 이를 참조한 논문을 1depth만큼 표현하는 네트워크 그래프를 렌더링 한다.
작업사항
리뷰 요청사항
실행화면