Skip to content

Improve Coverage Part 4 #1262

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Improve Coverage Part 4 #1262

wants to merge 12 commits into from

Conversation

jzmaddock
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.03%. Comparing base (9f03f29) to head (e494410).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1262      +/-   ##
===========================================
+ Coverage    93.91%   94.03%   +0.11%     
===========================================
  Files          661      664       +3     
  Lines        54866    54925      +59     
===========================================
+ Hits         51526    51646     +120     
+ Misses        3340     3279      -61     
Files with missing lines Coverage Δ
...e/boost/math/special_functions/jacobi_elliptic.hpp 100.00% <100.00%> (+2.72%) ⬆️
...lude/boost/math/special_functions/jacobi_theta.hpp 100.00% <100.00%> (+5.10%) ⬆️
include/boost/math/special_functions/lambert_w.hpp 100.00% <100.00%> (+4.59%) ⬆️
test/compile_test/instantiate.hpp 100.00% <ø> (ø)
test/test_jacobi.hpp 100.00% <100.00%> (ø)
test/test_jacobi_theta.hpp 98.38% <100.00%> (+0.11%) ⬆️
test/test_laguerre.hpp 100.00% <100.00%> (ø)
test/test_lambert_w.cpp 98.78% <100.00%> (+0.03%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f03f29...e494410. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckormanyos
Copy link
Member

Hi John (@jzmaddock) I see you are in lambert_w. I made a note a few days ago that if anyone gets in there, I'd like to see if the inclusions of <typeinfo>, <exception> and <iostream> can be removed. This is one of the few remaining files with those heavyweights in it.

Also <limits> is in twice.

Can they be removed?

@jzmaddock
Copy link
Collaborator Author

Can they be removed?

Looks like it, lets see what happens...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants