Pass alignment to holder::allocate #425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aca3c8 added an alignment argument to holder::allocate which defaults to 1. However, make_constructor.hpp uses this function to create storage for a pointer and was never changed to pass an alignment. This causes unaligned pointers to be created. This can be detected as a failure by running projects under Clang ubsan.
Fix patch to use boost python details to build without C++11.
|
This fix is incorporated via #392 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aca3c8 added an alignment argument to holder::allocate which defaults to 1. However, make_constructor.hpp uses this function to create storage for a pointer and was never changed to pass an alignment, so it uses the too-permissive default.
This causes unaligned pointers to be created on most architectures (although the x86 family tolerates it). This can be detected as a failure by running projects under Clang ubsan.